This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
The following commit(s) were added to refs/heads/master by this push:
new 33caa017 [ISSUE #825] Jave client TransactionProducer send need retry
(#826)
33caa017 is described below
commit 33caa017045d6dc0339fc32d61d8f8c7169068af
Author: qianye <[email protected]>
AuthorDate: Mon Oct 28 11:53:04 2024 +0800
[ISSUE #825] Jave client TransactionProducer send need retry (#826)
---
.github/workflows/java_build.yml | 2 +-
.../apache/rocketmq/client/java/impl/producer/ProducerImpl.java | 8 --------
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/.github/workflows/java_build.yml b/.github/workflows/java_build.yml
index 43609f86..b1697beb 100644
--- a/.github/workflows/java_build.yml
+++ b/.github/workflows/java_build.yml
@@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- os: [ubuntu-20.04, macos-11, windows-2022]
+ os: [ubuntu-20.04, macos-latest, windows-2022]
jdk: [11, 17]
steps:
- name: Checkout
diff --git
a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/producer/ProducerImpl.java
b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/producer/ProducerImpl.java
index a17d1958..a8021770 100644
---
a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/producer/ProducerImpl.java
+++
b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/producer/ProducerImpl.java
@@ -520,14 +520,6 @@ class ProducerImpl extends ClientImpl implements Producer {
maxAttempts, attempt, topic, messageIds, endpoints,
clientId, t);
return;
}
- // No need more attempts for transactional message.
- if (MessageType.TRANSACTION.equals(messageType)) {
- future0.setException(t);
- log.error("Failed to send transactional message finally,
maxAttempts=1, attempt={}, " +
- "topic={}, messageId(s)={}, endpoints={},
clientId={}", attempt, topic, messageIds,
- endpoints, clientId, t);
- return;
- }
// Try to do more attempts.
int nextAttempt = 1 + attempt;
// Retry immediately if the request is not throttled.
