lizhanhui commented on code in PR #8915:
URL: https://github.com/apache/rocketmq/pull/8915#discussion_r1842038737
##########
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java:
##########
@@ -500,6 +529,16 @@ public ConsumeQueueInterface
findOrCreateConsumeQueue(String topic, int queueId)
return oldLogic != null ? oldLogic : newLogic;
}
+ @Override
+ public ConcurrentMap<Integer, ConsumeQueueInterface>
findConsumeQueueMap(String topic) {
+ if (MixAll.isLmq(topic)) {
+ ConcurrentMap<Integer, ConsumeQueueInterface> result = new
ConcurrentHashMap<>(1);
+ result.put(MixAll.LMQ_QUEUE_ID, findOrCreateConsumeQueue(topic,
MixAll.LMQ_QUEUE_ID));
+ return result;
+ }
+ return super.findConsumeQueueMap(topic);
+ }
Review Comment:
This override SHOULD not be included in the pull request, as it makes sense
internally only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]