lizhimins commented on code in PR #9114: URL: https://github.com/apache/rocketmq/pull/9114#discussion_r1912779064
########## remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/RocksDBConfigToJsonRequestHeader.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.rocketmq.remoting.protocol.header; + +import java.util.ArrayList; +import java.util.List; +import org.apache.commons.lang3.StringUtils; +import org.apache.rocketmq.common.action.Action; +import org.apache.rocketmq.common.action.RocketMQAction; +import org.apache.rocketmq.remoting.CommandCustomHeader; +import org.apache.rocketmq.remoting.annotation.CFNotNull; +import org.apache.rocketmq.remoting.exception.RemotingCommandException; +import org.apache.rocketmq.remoting.protocol.RequestCode; + +@RocketMQAction(value = RequestCode.EXPORT_ROCKSDB_CONFIG_TO_JSON, action = Action.GET) +public class RocksDBConfigToJsonRequestHeader implements CommandCustomHeader { + private static final String CONFIG_TYPE_SEPARATOR = ";"; + + public enum ConfigType { + topics, + subscriptionGroups, + consumerOffsets; + + public static List<ConfigType> fromString(String ordinal) { + String[] configTypeStrings = StringUtils.split(ordinal, CONFIG_TYPE_SEPARATOR); + List<ConfigType> configTypes = new ArrayList<>(); + for (String configTypeString : configTypeStrings) { + if (StringUtils.isNotEmpty(configTypeString)) { + configTypes.add(ConfigType.valueOf(configTypeString)); + } + } + return configTypes; + } + + public static String toString(List<ConfigType> configTypes) { + StringBuilder sb = new StringBuilder(); + for (ConfigType configType : configTypes) { + sb.append(configType.name()).append(CONFIG_TYPE_SEPARATOR); + } + return sb.toString(); + } + } + + @CFNotNull + private String configType; + + @Override + public void checkFields() throws RemotingCommandException { + + } + + public List<ConfigType> getConfigType() { + return ConfigType.fromString(configType); + } + + public void setConfigType(List<ConfigType> configType) { Review Comment: fastjson will scan this method name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
