qianye1001 commented on code in PR #9162:
URL: https://github.com/apache/rocketmq/pull/9162#discussion_r1942174279
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -487,11 +494,14 @@ private RemotingCommand
updateAndGetGroupForbidden(ChannelHandlerContext ctx, Re
private RemotingCommand checkRocksdbCqWriteProgress(ChannelHandlerContext
ctx, RemotingCommand request) {
CheckRocksdbCqWriteResult result = new CheckRocksdbCqWriteResult();
result.setCheckStatus(CheckRocksdbCqWriteResult.CheckStatus.CHECK_IN_PROGRESS.getValue());
+ String taskId =
AdminAsyncTaskManager.createTask("checkRocksdbCqWriteProgress");
Review Comment:
use CompletableFuture when complete to record task success or error, you
can Change this runable to a future and add future arg in createTask like this ：
CompletableFuture<T> future = ......
adminAsyncTaskManager.createTask("checkRocksdbCqWriteProgress", future);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
