This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 40e3aa938f [ISSUE #9553] Improve performance by avoiding repeated
get(key) (#9554)
40e3aa938f is described below
commit 40e3aa938f254be6f85532ff8b0036921aa5ab73
Author: Xiao Yang <[email protected]>
AuthorDate: Sun Jul 20 10:05:52 2025 +0800
[ISSUE #9553] Improve performance by avoiding repeated get(key) (#9554)
* [ISSUE #9553] Improve performance by avoiding repeated get(key)
* Update
---
.../java/org/apache/rocketmq/broker/client/ConsumerManager.java | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java
b/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java
index 341bbb5dad..176456043b 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java
@@ -22,6 +22,7 @@ import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Map.Entry;
+import java.util.Optional;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
@@ -386,11 +387,7 @@ public class ConsumerManager {
}
public HashSet<String> queryTopicConsumeByWho(final String topic) {
- HashSet<String> groups = new HashSet<>();
- if (this.topicGroupTable.get(topic) != null) {
- groups.addAll(this.topicGroupTable.get(topic));
- }
- return groups;
+ return new
HashSet<>(Optional.ofNullable(topicGroupTable.get(topic)).orElseGet(HashSet::new));
}
public void appendConsumerIdsChangeListener(ConsumerIdsChangeListener
listener) {