tianliuliu commented on code in PR #9579:
URL: https://github.com/apache/rocketmq/pull/9579#discussion_r2258706010
##########
broker/src/main/java/org/apache/rocketmq/broker/longpolling/PopLongPollingService.java:
##########
@@ -52,21 +54,27 @@ public class PopLongPollingService extends ServiceThread {
LoggerFactory.getLogger(LoggerName.ROCKETMQ_POP_LOGGER_NAME);
private final BrokerController brokerController;
private final NettyRequestProcessor processor;
- private final ConcurrentLinkedHashMap<String, ConcurrentHashMap<String,
Byte>> topicCidMap;
- private final ConcurrentLinkedHashMap<String,
ConcurrentSkipListSet<PopRequest>> pollingMap;
+ private final Cache<String, ConcurrentHashMap<String, Byte>> topicCidMap;
+ private final Cache<String, ConcurrentSkipListSet<PopRequest>> pollingMap;
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]