KingCide commented on code in PR #9637:
URL: https://github.com/apache/rocketmq/pull/9637#discussion_r2321355801
##########
broker/src/main/java/org/apache/rocketmq/broker/longpolling/PopLongPollingService.java:
##########
@@ -159,15 +161,28 @@ public void notifyMessageArrivingWithRetryTopic(final
String topic, final int qu
public void notifyMessageArrivingWithRetryTopic(final String topic, final
int queueId, long offset,
Long tagsCode, long msgStoreTime, byte[] filterBitMap, Map<String,
String> properties) {
- String notifyTopic;
- if (KeyBuilder.isPopRetryTopicV2(topic)) {
- notifyTopic = KeyBuilder.parseNormalTopic(topic);
+ String prefix = MixAll.RETRY_GROUP_TOPIC_PREFIX;
+ if (topic.startsWith(prefix)) {
+ // 从properties获取原始topic名称
+ String originTopic =
properties.get(MessageConst.PROPERTY_ORIGIN_TOPIC);
+ //根据原始topic和retryTopic，最后获得retryTopic对应的cid (可能还可以与topicCidMap验证一下)
Review Comment:
Done.
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
