RongtongJin commented on code in PR #9655:
URL: https://github.com/apache/rocketmq/pull/9655#discussion_r2488478962
##########
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##########
@@ -198,7 +198,7 @@ public TimerMessageStore(final MessageStore messageStore,
final MessageStoreConf
bufferLocal = new ThreadLocal<ByteBuffer>() {
@Override
protected ByteBuffer initialValue() {
- return
ByteBuffer.allocateDirect(storeConfig.getMaxMessageSize() + 100);
+ return
ByteBuffer.allocateDirect(storeConfig.getMaxMessageSize() +
storeConfig.getTimerMessageBufferSize());
Review Comment:
int maxMessageSize = Integer.MAX_VALUE - maxMessageBodySize >= 64 *
1024 ?
maxMessageBodySize + 64 * 1024 : Integer.MAX_VALUE;
Wouldn't it be better to follow the settings in MessageExtEncoder (lines
53–54)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
