yangqikun-bd commented on code in PR #10308:
URL: https://github.com/apache/rocketmq/pull/10308#discussion_r3253297787
##########
store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java:
##########
@@ -558,6 +560,21 @@ public CompletableFuture<PutMessageResult>
asyncPutMessage(MessageExtBrokerInner
AppendFuture<AppendEntryResponse> dledgerFuture;
EncodeResult encodeResult;
+ final MessageStoreConfig storeConfig =
this.defaultMessageStore.getMessageStoreConfig();
+ final boolean isMultiDispatchMsg = storeConfig.isEnableLmq() &&
msg.needDispatchLMQ();
+ if (isMultiDispatchMsg) {
+ try {
+ LmqDispatch.wrapLmqDispatch(this.defaultMessageStore, msg);
Review Comment:
maybe need to keep in lock, because it may cause data race by
updateLmqOffsets
##########
store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java:
##########
@@ -558,6 +560,21 @@ public CompletableFuture<PutMessageResult>
asyncPutMessage(MessageExtBrokerInner
AppendFuture<AppendEntryResponse> dledgerFuture;
EncodeResult encodeResult;
+ final MessageStoreConfig storeConfig =
this.defaultMessageStore.getMessageStoreConfig();
+ final boolean isMultiDispatchMsg = storeConfig.isEnableLmq() &&
msg.needDispatchLMQ();
+ if (isMultiDispatchMsg) {
+ try {
+ LmqDispatch.wrapLmqDispatch(this.defaultMessageStore, msg);
Review Comment:
maybe need to keep in lock? because it may cause data race by
updateLmqOffsets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
