qianye1001 commented on code in PR #108:
URL: https://github.com/apache/rocketmq-apis/pull/108#discussion_r3265165462
##########
apache/rocketmq/v2/definition.proto:
##########
@@ -523,6 +530,31 @@ message Settings {
UA user_agent = 7;
Metric metric = 8;
+
+ // Application-defined metadata associated with this client instance.
+ // These properties are for observability, troubleshooting, auditing and
+ // management only.
+ //
+ // Constraints:
+ // - Maximum 32 key-value pairs per client instance
+ // - Key length: 1-64 characters, must match pattern [a-zA-Z][a-zA-Z0-9_.-]*
+ // - Value length: 0-256 characters
+ // - Total serialized size: <= 4KB
+ //
+ // Example keys used by some organizations: app, env, region, zone, version,
instance, owner.
Review Comment:
去掉这里的 // Example keys used by some organizations: app, env, region, zone,
version, instance, owner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
