RongtongJin opened a new pull request, #10407:
URL: https://github.com/apache/rocketmq/pull/10407

   ## Summary
   
   This is a follow-up for the store tests called out around #10404 and the 
broader #10383 test stability/dependency work. It keeps the tests enabled and 
makes the repeated-run behavior deterministic instead of quarantining them.
   
   - Use dynamic HA ports in `AutoSwitchHATest` and pass the actual bound HA 
address after startup.
   - Wait for HA replication connection establishment before producing messages 
after master/slave role changes.
   - Avoid double shutdown/destroy in `AutoSwitchHATest` teardown paths to 
prevent repeated-run file lock noise.
   - Use dynamically allocated DLedger ports (`localhost:0` for single-node 
tests, available ephemeral ports for two-node tests) instead of the shared 
`nextPort()` sequence.
   
   ## Validation
   
   - Reproduced `AutoSwitchHATest#testAddBroker` failure with `127.0.0.1:10912` 
pre-bound; it failed before the change and passed after the dynamic-port fix.
   - `mvn -q -pl store -am -DskipITs -DfailIfNoTests=false 
-Dcheckstyle.skip=true -Dspotbugs.skip=true 
-Dtest=AutoSwitchHATest#testConfirmOffset test` passed 3 consecutive runs.
   - `mvn -q -pl store -am -DskipITs -DfailIfNoTests=false 
-Dcheckstyle.skip=true -Dspotbugs.skip=true -Dtest=AutoSwitchHATest test` 
passed; `Tests run: 10, Failures: 0, Errors: 0, Skipped: 1`, with no `release 
file lock error` in the log.
   - `mvn -q -pl store -am -DskipITs -DfailIfNoTests=false 
-Dcheckstyle.skip=true -Dspotbugs.skip=true 
-Dtest=DLedgerCommitlogTest,DLedgerMultiPathTest test` passed on this macOS 
environment with the existing platform assumptions (`Tests run: 2, Failures: 0, 
Errors: 0, Skipped: 2`).
   - `mvn -q -pl store -am -DskipITs -Dcheckstyle.skip=true 
-Dspotbugs.skip=true test-compile` passed.
   
   Bazel validation was not run locally because `bazel` is not installed in 
this environment (`zsh: command not found: bazel`).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to