skt-shinyruo opened a new pull request, #10428: URL: https://github.com/apache/rocketmq/pull/10428
## Summary - add an optional `policyType` parameter to the ACL delete path in mqadmin, admin, client, and remoting request header - preserve existing behavior when `policyType` is not provided, while allowing `mqadmin deleteAcl` to target `PolicyType=Default` - add focused regression coverage in client, broker, and auth tests for deleting ACLs with explicit policy types ## Root Cause `DeleteAclRequestHeader` supports `policyType`, but the delete path from mqadmin to broker did not populate it. When the field is absent, broker-side delete handling falls back to `PolicyType.CUSTOM`, so deleting a `DEFAULT` policy entry cannot target the intended ACL rule. ## Test Plan - `mvn -o -pl tools -am -DskipTests compile` - `mvn -o -pl client -am -DfailIfNoTests=false -Dtest=MQClientAPIImplTest#testDeleteAcl+testDeleteAclWithPolicyType test` - `mvn -o -pl broker -am -DfailIfNoTests=false -Dtest=AdminBrokerProcessorTest#testDeleteAcl+testDeleteAclWithPolicyType test` - `mvn -o -pl auth -am -DfailIfNoTests=false -Dtest=AuthorizationMetadataManagerTest#deleteAcl test` Closes #9966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
