qianye1001 commented on issue #10434: URL: https://github.com/apache/rocketmq/issues/10434#issuecomment-4645194498
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** feasible — pure wiring at the gRPC layer, low complexity (~4-5 files, mechanical changes following established patterns). **Scope:** `proxy` module only: - `GrpcMessagingActivity.java` — add interface methods - `DefaultGrpcMessagingActivity.java` — add default implementations - `GrpcMessagingApplication.java` — add `@Override` for `queryOffset` / `getOffset` - New `OffsetActivity.java` in `grpc/v2/consumer/` - Unit tests against mocked `MessagingProcessor` **Compatibility:** No breaking changes — additive gRPC methods, existing clients unaffected. **Key Finding:** `MessagingProcessor.java` already exposes `queryConsumerOffset()`, `getMaxOffset()`, and `updateConsumerOffset()` — all the business logic exists. The 13+ existing `*Activity` classes provide a well-established wiring pattern to follow. **Blocker to verify:** The proto definitions (`QueryOffsetRequest/Response`, `GetOffsetRequest/Response`, etc.) come from the external `rocketmq-proto` repository (consumed as a Maven dependency). No `.proto` file in this repo declares these RPCs. Before implementation: 1. Confirm `rocketmq-proto` already publishes these stubs (and which version) 2. If not, a companion PR to `apache/rocketmq-clients` (proto repo) is required first Once proto stubs are available, the proxy wiring is straightforward. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
