oss-taishan-ai commented on issue #10442: URL: https://github.com/apache/rocketmq/issues/10442#issuecomment-4648758536
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** feasible **Scope:** common/message module (8 files) **Compatibility:** backward compatible (internal optimization, no API changes) **Assessment:** This is a well-researched performance optimization targeting the message properties encode/decode hot path. The heap dump analysis provides concrete evidence: - HashMap$Node[] occupies 21.0% of live heap - String duplication is significant (only 21,873 distinct values out of 100,000 sampled) - The proposed FlatPropertiesMap with ThreadLocal reuse and string interning is a sound approach The solution addresses the root cause (per-message HashMap allocation) with a compact flat array structure. The zero-copy serialization via ByteBuffer is particularly elegant. **Recommendation:** This optimization could significantly reduce GC pressure on high-throughput broker deployments. The approach is technically sound and the scope is well-contained. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
