oss-taishan-ai commented on issue #10446: URL: https://github.com/apache/rocketmq/issues/10446#issuecomment-4651391280
## Assessment by github-manager-bot **Type:** Enhancement **Priority:** Medium ### Summary This issue proposes two improvements to `AdminBrokerProcessor`: 1. Remove `synchronized` from `deleteTopic` since `topicConfigTable` is already a `ConcurrentHashMap` 2. Add batch deletion APIs: `DELETE_TOPIC_IN_BROKER_LIST` and `DELETE_SUBSCRIPTIONGROUP_LIST` ### Feasibility Analysis ✅ **Technically sound** — The reasoning is correct: - `ConcurrentHashMap` provides thread-safe operations without external synchronization - Batch APIs following the `*_LIST` convention are consistent with existing patterns (`UPDATE_AND_CREATE_TOPIC_LIST`, etc.) - Reduces admin-request backlog during bulk cleanup operations ✅ **Clear motivation** — The issue correctly identifies: - Current `synchronized` forces serial execution - N persistence I/O calls for N deletions - Batch API reduces network round-trips ### Suggestions 1. Consider adding a maximum batch size limit to prevent excessive memory usage 2. Ensure proper error handling for partial failures in batch operations 3. Add unit tests for the new batch APIs ### Verdict **Valid enhancement request** — Recommended for implementation. The proposed changes align with RocketMQ's existing API design patterns and address a legitimate performance concern. --- *Automated assessment by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
