wang-jiahua commented on code in PR #10448:
URL: https://github.com/apache/rocketmq/pull/10448#discussion_r3377694093
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -758,7 +766,7 @@ private synchronized RemotingCommand
updateAndCreateStaticTopic(ChannelHandlerCo
return response;
}
- private synchronized RemotingCommand deleteTopic(ChannelHandlerContext ctx,
+ private RemotingCommand deleteTopic(ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
Review Comment:
Update: scope of this PR has been narrowed back to **only the new batch
APIs**. The `synchronized` keyword on `deleteTopic` is now restored to its
original behavior, and the new `deleteTopicList` /
`deleteSubscriptionGroupList` are also marked `synchronized` to stay consistent
with the existing `deleteTopic` / `updateAndCreate*` family. The race-condition
concern you raised therefore no longer applies in this PR. Removing
`synchronized` from `deleteTopic` is being discussed separately in #9997 /
#9998 and is intentionally left out of this scope. Code at 75ae0ef8d.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
