oss-sentinel-ai commented on issue #10450: URL: https://github.com/apache/rocketmq/issues/10450#issuecomment-4657555585
## Assessment by github-manager-bot **Classification:** 🔧 Enhancement ### Summary The issue proposes introducing selective double-write in `CombineConsumeQueueStore`. Currently, every topic is double-written to both file-based ConsumeQueue and RocksDB ConsumeQueue. The proposal is to make this opt-in via a new switch `rocksdbCQSelectiveDoubleWriteEnable`, since not all topics need double-write (only LITE topics require it for LMQ). ### Analysis This is a well-motivated performance optimization: - **Problem**: Unnecessary double-write overhead for topics that don't need RocksDB ConsumeQueue - **Solution**: Introduce a configurable switch to control double-write behavior per topic type - **Backward compatibility**: The switch is opt-in, avoiding breaking changes ### Recommendation ✅ **Valid enhancement request.** The proposal is technically sound and addresses a real performance concern. The opt-in approach ensures backward compatibility. This requires maintainer review to assess the design and implementation approach. --- *Automated assessment by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
