oss-sentinel-ai commented on issue #10458:
URL: https://github.com/apache/rocketmq/issues/10458#issuecomment-4666347112
## Issue Evaluation
**Type:** Bug / Code Quality
**Category:** Input Validation
**Priority:** Medium
### Assessment
Valid code quality issue. The `MessageBatch.generateFromList` method uses
Java `assert` statements for input validation:
```java
assert messages != null;
assert messages.size() > 0;
```
This is problematic because:
1. **Inconsistent behavior**: With assertions disabled (default in
production), null/empty input passes validation
2. **Delayed failure**: Invalid input may cause `NullPointerException`
later, making debugging harder
3. **API contract violation**: Public API should have explicit, consistent
parameter validation
### Expected Fix
Replace `assert` with explicit validation:
```java
if (messages == null || messages.isEmpty()) {
throw new IllegalArgumentException("messages cannot be null or empty");
}
```
✅ **Accepted** — This is a legitimate input validation issue that should be
fixed for API consistency.
---
*🤖 Automated evaluation by oss-sentinel-ai*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
