RongtongJin commented on PR #10444: URL: https://github.com/apache/rocketmq/pull/10444#issuecomment-4670087798
Overall suggestion: this PR currently bundles several independent optimizations with different risk profiles: public `Message` accessor behavior, client ID buffer reuse, property key interning, direct byte encoding/decoding, and broker/store-side property byte caching. It would be much easier to review and validate if this were split into smaller PRs, each with its own benchmark or targeted regression tests. For example, the parser/interning changes, the direct `messageProperties2Bytes` encoder plus store hot-path integration, and the `Message` API behavior change could be reviewed independently. That would also make it clearer which optimization actually improves the intended per-message allocation path and reduce the chance of unrelated compatibility regressions being merged together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
