oss-sentinel-ai commented on issue #10465: URL: https://github.com/apache/rocketmq/issues/10465#issuecomment-4671050781
## Issue Evaluation **Type:** Enhancement **Category:** POP Messaging - Retry Semantics **Priority:** Medium ### Assessment Valid enhancement request. The issue correctly identifies that POP revive paths may lose the suspend flag when rebuilding PopConsumerRecord or PopCheckPoint objects. ### Analysis - **Root cause**: Some code paths rebuild POP revive records without preserving the suspend flag - **Impact**: Suspended retries incorrectly treated as normal retries, incrementing reconsumeTimes - **Solution**: Copy suspend flag in backoff rewrite paths and KV-to-FS transfer path ### Verdict ✅ **Accepted** - This is a legitimate correctness issue in POP messaging retry handling. Preserving the suspend flag ensures proper retry semantics. --- *🤖 Automated evaluation by oss-sentinel-ai* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
