The GitHub Actions job "Golang Coverage" on rocketmq-clients.git/master has 
failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
f17e6dff2938b9c4b5a9514e5acfae2dfa88fd16 / guyinyou 
<[email protected]>
[Go] Fix Commit/RollBack always returning nil in transaction (#1271)

The Commit() and RollBack() methods in transactionImpl silently swallowed
errors from endTransaction: errors were only logged inside the Range
callback, and the caller always received nil, making it impossible to
detect a failed commit or rollback.

What changed:
- Capture the error from the Range closure and return it to the caller.
- Stop Range iteration on first error (matching Java's fail-fast behavior).
- Return an error when messageSendReceiptMap is empty, aligning with the
  Java client's IllegalStateException ("Transactional message has not been
  sent yet").

Affected: golang/transaction.go Commit(), RollBack()

Co-authored-by: guyinyou <[email protected]>

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/27390689980

With regards,
GitHub Actions via GitBox

Reply via email to