lollipopjin commented on code in PR #10473:
URL: https://github.com/apache/rocketmq/pull/10473#discussion_r3400395694
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/index/IndexStoreService.java:
##########
@@ -137,6 +137,10 @@ private void recover() {
log.info("IndexStoreService#recover, load local file,
timestamp={}", indexFile.getTimestamp());
} catch (Exception e) {
log.error("IndexStoreService#recover, load local file
error, destroying={}", file.getName(), e);
+ try {
Review Comment:
Deleting the index file on any exception is too aggressive — transient
failures (OOM, I/O timeout) would cause index data loss. Consider only deleting
on data-integrity errors, or renaming to `.corrupt` for manual inspection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
