RockteMQ-AI commented on issue #10510: URL: https://github.com/apache/rocketmq/issues/10510#issuecomment-4704188965
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** `proxy` module — `GrpcServerBuilder`, `ProxyConfig` **Compatibility:** Backward compatible, default values are more permissive than current implicit defaults **Code Verification:** - ✅ `GrpcServerBuilder.java` exists at `proxy/src/main/java/org/apache/rocketmq/proxy/grpc/GrpcServerBuilder.java` - ✅ `ProxyConfig.java` exists at `proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java` - ✅ Confirmed: No `permitKeepAliveTime` or `permitKeepAliveWithoutCalls` configuration currently exists - ✅ Confirmed: `GrpcServerBuilder` does not call these methods on `serverBuilder` **Assessment:** The issue correctly identifies that gRPC server defaults (5min keepalive time, no keepalive without calls) cause slow dead-connection detection. The proposed solution is straightforward: 1. Add two configurable parameters to `ProxyConfig` with sensible defaults (10s, true) 2. Apply them in `GrpcServerBuilder` via `serverBuilder.permitKeepAliveTime()` and `.permitKeepAliveWithoutCalls()` The overhead analysis is accurate (~8KB/hour per connection at 30s interval). This is a low-risk, high-value improvement for connection reliability. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
