RockteMQ-AI commented on issue #10515: URL: https://github.com/apache/rocketmq/issues/10515#issuecomment-4711380949
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** Well-structured proposal with three independent optimizations: 1. **ConsumerOffsetManager key caching** — Valid. Caching `topic + "@" + group` keys eliminates per-call `StringBuilder` allocation for a stable (topic, group) pair set. The 2-level `ConcurrentHashMap` approach is reasonable. 2. **PullRequestHoldService.buildKey() caching** — Valid. Per-topic `String[]` indexed by queueId avoids `StringBuilder` + `toString()` on every pull hold/check. 3. **TransactionMetricsFlushService busy-spin** — This is a **correctness bug**, not just an enhancement. `waitForRunning()` inside the `if` branch means the loop spins without yielding when the interval has not elapsed. This should be tracked as a separate bug fix if needed. **Feasibility:** Feasible. Each optimization is isolated and low-risk. **Scope:** broker module (store/remoting layers) **Compatibility:** No breaking changes. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
