RockteMQ-AI commented on issue #10518: URL: https://github.com/apache/rocketmq/issues/10518#issuecomment-4717311010
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** Client module — `LocalFileOffsetStore` (or equivalent offset persistence class), consumer config **Compatibility:** Fully backward compatible (default `false` preserves existing throw-on-corruption behavior) **Assessment:** This is a well-structured feature request addressing a real operational pain point. When offset files get corrupted (e.g., power loss during `persistAll()`), the consumer currently crashes with a misleading error message, and there is no built-in way to recover gracefully. The proposed solution — an opt-in config `rocketmq.client.localOffsetStore.ignoreCorrupted` — is: - **Minimal in scope**: Only modifies the exception handling path in `readLocalOffsetBak()` to optionally return null instead of throwing - **Safe by default**: Existing behavior is unchanged unless explicitly opted in - **Well-reasoned**: The issue author has considered alternatives (always-null, manual cleanup, tmpfs redirect) and explained why this approach is preferable The implementation would involve: 1. Adding the config property to `ClientConfig` (or equivalent) 2. Modifying `readLocalOffsetBak()` to check the flag before throwing 3. Adding unit tests for both `true` and `false` paths This is a reasonable enhancement that improves consumer resilience. Whether to accept it is a maintainer decision. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
