f1amingo opened a new pull request, #10547:
URL: https://github.com/apache/rocketmq/pull/10547
### Which Issue(s) This PR Fixes
Fixes #10546
### Brief Description
The `rejectRequest()` method in `NettyRequestProcessor` interface requires
every implementation to provide an override, yet 20+ implementations across the
codebase simply `return false`, with only `SendMessageProcessor` and
`PullMessageProcessor` containing actual logic.
This PR converts `boolean rejectRequest()` to `default boolean
rejectRequest() { return false; }` and removes all redundant `return false`
overrides, reducing ~128 lines of boilerplate code.
- Semantically equivalent: all removed overrides already return false
- Existing overrides with real logic (Send/Pull) remain unaffected
- Compatible with Java 8+ (project target)
### How Did You Test This Change?
Existing unit tests remain unchanged and should all pass. This is a pure
refactoring with no behavioral change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
