qianye1001 commented on PR #10519: URL: https://github.com/apache/rocketmq/pull/10519#issuecomment-4828612354
@fuyou001 Thanks, agreed. Fixed in d1d6e3e8ddbc13224a216fa1473e55225eb27ec1. The proxy fallback is now restricted to the explicit unsupported case only: the real exception must be an `MQBrokerException` with `ResponseCode.REQUEST_CODE_NOT_SUPPORTED`. For ambiguous failures such as timeout/transport failure/lost response, `processBrokerChangeInvisibleTime` now completes the batch entries with `INTERNAL_SERVER_ERROR` and does not retry single `changeInvisibleTime`, so it will not create a second CK with a new `changedPopTime` after the broker may already have applied the batch. Added regression coverage in `ConsumerProcessorTest` for both paths: - `testBatchChangeInvisibleTimeFallbackOnlyWhenRequestCodeNotSupported` - `testBatchChangeInvisibleTimeDoesNotFallbackOnAmbiguousFailure` Verified locally: - `mvn -pl proxy -am -DfailIfNoTests=false -Dtest=ConsumerProcessorTest test` - `mvn -pl broker -am -DfailIfNoTests=false -Dtest=ChangeInvisibleTimeProcessorTest test` Comment addressed: https://github.com/apache/rocketmq/pull/10519#issuecomment-4741426672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
