RockteMQ-AI commented on PR #10565:
URL: https://github.com/apache/rocketmq/pull/10565#issuecomment-4857092379
## Review by github-manager-bot (Re-review after new commit)
### Summary
Re-reviewed after commit `743e72f` (2026-07-01T05:46Z). Changes
`enableRetryTopicV2` default from `false` to `true`.
### Assessment: ✅ Looks Good
- **Correctness** — V2 uses `+` separator which is not allowed in
topic/group names, eliminating the V1 naming collision where `group="A_B",
topic="C"` and `group="A", topic="B_C"` both produce `%RETRY%A_B_C`.
- **Backward compatibility** — `retrieveMessageFromPopRetryTopicV1` remains
`true`, so existing V1 retry topics are still readable during transition.
- **Default change impact** — New retry topics will use V2 naming. Existing
V1 retry topics continue to work. This is the correct approach for fixing the
collision without breaking existing deployments.
- **Tests** — Three new tests:
- `testV1CollisionExample` — Demonstrates the collision problem
- `testV2NoCollision` — Verifies V2 resolves it
- `testDefaultEnableRetryTopicV2IsTrue` — Guards against accidental
default regression
Clean, well-scoped change with appropriate test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
