frinda commented on code in PR #10566:
URL: https://github.com/apache/rocketmq/pull/10566#discussion_r3541875620
##########
store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java:
##########
@@ -1271,7 +1279,13 @@ public void initializeWithOffset(long offset, long
minPhyOffset) {
// transientStorePool is null, only need set wrote position here
MappedFile mappedFile = mappedFileQueue.getLastMappedFile(offset *
ConsumeQueue.CQ_STORE_UNIT_SIZE, true);
- fillPreBlank(mappedFile, offset * ConsumeQueue.CQ_STORE_UNIT_SIZE);
+ if (mappedFile != null && mappedFile.hold()) {
+ try {
+ fillPreBlank(mappedFile, offset *
ConsumeQueue.CQ_STORE_UNIT_SIZE);
+ } finally {
+ mappedFile.release();
+ }
+ }
Review Comment:
> org.apache.rocketmq.store.logfile.DefaultMappedFile#appendMessage(byte[],
int, int) I think this place also needs to be protected via reference counting
(hold()/release()). Recently, I encountered an issue where the standby server
suddenly crashed during primary-standby synchronization.
>
> hs_error log as follows：
##########
store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java:
##########
@@ -1271,7 +1279,13 @@ public void initializeWithOffset(long offset, long
minPhyOffset) {
// transientStorePool is null, only need set wrote position here
MappedFile mappedFile = mappedFileQueue.getLastMappedFile(offset *
ConsumeQueue.CQ_STORE_UNIT_SIZE, true);
- fillPreBlank(mappedFile, offset * ConsumeQueue.CQ_STORE_UNIT_SIZE);
+ if (mappedFile != null && mappedFile.hold()) {
+ try {
+ fillPreBlank(mappedFile, offset *
ConsumeQueue.CQ_STORE_UNIT_SIZE);
+ } finally {
+ mappedFile.release();
+ }
+ }
Review Comment:
> org.apache.rocketmq.store.logfile.DefaultMappedFile#appendMessage(byte[],
int, int) I think this place also needs to be protected via reference counting
(hold()/release()). Recently, I encountered an issue where the standby server
suddenly crashed during primary-standby synchronization.
>
> hs_error log as follows：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
