pilichoumao opened a new pull request, #10603:
URL: https://github.com/apache/rocketmq/pull/10603

   ## Summary
   
   This draft PR contains the RocketMQ-side implementation for RIP-2 Proxy 
Admin M1 online client query.
   
   It adds the generated public `apache.rocketmq.v2.ProxyAdminService` endpoint 
for:
   
   - `ListClients`
   - `DescribeClient`
   - `ListClientsByGroup`
   - `ListClientsByTopic`
   
   The endpoint is registered on the independent Proxy admin gRPC server and 
delegates to the existing internal read model, ACL, metrics, executor, and 
lifecycle wiring.
   
   ## Important API Gate
   
   This implementation currently compiles against the local contest artifact:
   
   `org.apache.rocketmq:rocketmq-proto:2.2.0-rip2-SNAPSHOT`
   
   That artifact is generated from the companion API proposal branch and draft 
PR:
   
   - API draft PR: https://github.com/apache/rocketmq-apis/pull/112
   - API fork branch: 
https://github.com/pilichoumao/rocketmq-apis/tree/rip2-proxy-admin-public-api
   
   Please treat this PR as a downstream implementation draft for review. It 
should not be merged until the public API ownership, field numbers, generated 
artifact version, and publication path are accepted by the community.
   
   ## Implementation Notes
   
   - Keeps the M1 public scope limited to omitted scope / 
`PROXY_SCOPE_LOCAL_PROXY`.
   - Rejects `PROXY_SCOPE_ALL_PROXIES` and `PROXY_SCOPE_PROXY_ID` at the public 
endpoint until multi-proxy semantics are finalized.
   - Keeps admin traffic on the independent Proxy admin gRPC server rather than 
the data-plane messaging service.
   - Reuses `proxy.admin.client` ACL, metered service wrappers, query executor 
isolation, and lifecycle-fed read model.
   - Includes English and Chinese submission/smoke documentation.
   
   ## Verification
   
   Fresh focused verification on JDK 17:
   
   ```bash
   JAVA_HOME="$(/usr/libexec/java_home -v 17)" \
   mvn -pl proxy -am \
   
-Dtest=GrpcProxyAdminApplicationTest,ProxyStartupTest,GrpcProxyAdminWiringTest \
   -DfailIfNoTests=false test -DskipITs
   ```
   
   Result:
   
   ```text
   Tests run: 36, Failures: 0, Errors: 0, Skipped: 0
   BUILD SUCCESS
   ```
   
   Earlier full contest verification recorded in the submission package:
   
   ```text
   Broad proxy admin verification: Tests run: 707, Failures: 0, Errors: 0, 
Skipped: 0
   Package smoke: BUILD SUCCESS
   ```
   
   JDK 17 may print JaCoCo 0.8.5 instrumentation stack traces; those are 
environment noise when Surefire reports zero failures/errors and Maven exits 
successfully.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to