lizhimins opened a new pull request, #1301: URL: https://github.com/apache/rocketmq-clients/pull/1301
## Summary Fix thread safety and correctness bugs in the gRPC telemetry bidirectional streaming reactor and client manager. ## Fixes ### TelemetryBidiReactor - **settings_received_ data race**: Changed `bool settings_received_` to `std::atomic<bool>` with `compare_exchange_strong` to prevent concurrent access from telemetry and user threads - **close() use-after-free**: `writes_` list was cleared before `TryCancel()`, but gRPC held raw pointers to list elements. Moved `writes_.clear()` to after the OnDone wait loop - **RemoveHold() ordering**: Ensure `RemoveHold()` is called correctly to avoid premature stream destruction ### ClientManagerImpl - **Missing callback invocation**: Added callback for `ILLEGAL_CONSUMER_GROUP` error path - **Send state guard**: Added state check before invoking send callback to prevent null dereference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
