RockteMQ-AI commented on issue #10604: URL: https://github.com/apache/rocketmq/issues/10604#issuecomment-4931903913
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** In `TopicConfigManager#buildSerializeWrapper` (line 650-652), when `enableSplitRegistration` is enabled, the DataVersion is advanced by directly calling `this.getDataVersion().nextVersion()`. This bypasses the overridable `updateDataVersion()` method. Under RocksDB config storage, `RocksDBTopicConfigManager` overrides `updateDataVersion()` (line 199-204) to call `rocksDBConfigManager.updateKvDataVersion()`, which persists the version into RocksDB. By calling `getDataVersion().nextVersion()` directly, the version is only bumped in memory and never persisted, and the `stateMachineVersion` is not included. **Impact:** Topic config DataVersion becomes inconsistent between memory and RocksDB storage after split registration. On broker restart, the stale persisted version may cause unnecessary full re-registration or config mismatch. **Severity:** medium **Fix:** Replace `this.getDataVersion().nextVersion()` with `this.updateDataVersion()` in `buildSerializeWrapper` to use the unified, overridable path. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
