Aias00 commented on PR #10585: URL: https://github.com/apache/rocketmq/pull/10585#issuecomment-4947171416
Re: the suggestion to audit other `getClientSettings(ctx)` call sites — done. The three other call sites are safe: - `ClientActivity#heartbeat` (line 102): already has an explicit `if (clientSettings == null)` guard returning `UNRECOGNIZED_CLIENT_TYPE`. - `ClientActivity#processClientSettings` (line 406): calls `updateClientSettings(...)` immediately before the read, so settings are guaranteed cached. - `GrpcClientChannel#getChannelExtendAttribute` (line 84): uses `getRawClientSettings` with an explicit `if (settings == null) return null;` guard. The producer activities (`SendMessageActivity`, `RecallMessageActivity`, `ForwardMessageToDLQActivity`) don't read client settings at all — they only thread the manager through the constructor. So `ReceiveMessageActivity` was the only site that dereferenced the settings without a null check; no further changes needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
