RockteMQ-AI commented on issue #10641: URL: https://github.com/apache/rocketmq/issues/10641#issuecomment-5031569245
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** `DLedgerCommitLog`, `MessageStoreConfig` (Broker DLedger-specific accessors) **Compatibility:** No breaking changes — existing clusters continue to operate unchanged This is a well-scoped deprecation. The distinction between Broker DLedger mode (deprecated) and DLedger-backed Controller (retained) is clearly documented. The approach — add `@Deprecated` annotations + startup warning log while keeping full backward compatibility — is the correct way to signal deprecation without disrupting existing deployments. **Assessment:** - Clear motivation: Controller mode is the recommended path for new deployments - Compatibility is properly considered (no removal, just deprecation markers) - Scope is correctly limited to Broker DLedger mode only This looks ready for implementation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
