PiliLily commented on issue #10599:
URL: https://github.com/apache/rocketmq/issues/10599#issuecomment-5062290193

   I am taking a focused, protocol-independent M1 foundation task before adding
   the public Proxy Admin RPC surface.
   
   The first PR will address correctness gaps in the current gRPC client runtime
   state:
   
   - one generation-aware session per Telemetry stream;
   - same-client reconnect atomically replaces the previous session;
   - connection time and monotonic last-active time;
   - compare-and-remove by the exact channel identity, so delayed producer,
     consumer, or stream callbacks cannot delete a replacement session;
   - Settings ownership bound to the same generation, preventing the equivalent
     cross-map cleanup race;
   - unified cleanup for Telemetry completion/error and local unregister
     listeners.
   
   This PR will not add proto definitions, an admin port, ACL resources, list
   indexes, or any M2 route/Pop/Batch capability. It is intended to stay within
   roughly 6–7 production/test files and be independently useful for the M1 
online
   client view.
   
   I will keep the public contract in `rocketmq-apis` and the later admin 
service
   work separate. For M1 I am following this issue's single-Proxy local-view
   non-goal; multi-Proxy aggregation remains an upper-layer concern. I will 
attach
   the focused JDK 8 test/build evidence to the PR.
   
   I also reviewed #10611: this work does not duplicate its diagnostic snapshot
   getters. It establishes lifecycle ownership needed before any list/pagination
   API treats the channel map as an online-client source of truth.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to