lizhimins opened a new pull request, #113:
URL: https://github.com/apache/rocketmq-apis/pull/113

   ## Summary
   
   Today the gRPC `Admin` service only exposes a single `ChangeLogLevel` RPC, 
while all cluster administration and diagnostics still go through the legacy 
Remoting binary protocol. This PR expands `admin.proto` into a full 
control-plane surface so that management operations can share the same gRPC + 
Protobuf stack as the data plane, lowering the bar for multi-language admin 
tooling.
   
   Adds 15 RPCs to `service Admin`:
   
   - **Topic**: `DescribeTopicStatus`, `GetTopicRoute`
   - **Subscription**: `ListSubscription`, `DescribeSubscription`, 
`DeleteSubscription`
   - **Consumption / lag**: `DescribeGroupAccumulation`, `QueryTimeSpan`, 
`ResetGroupOffset`
   - **Message**: `QueryMessage`, `AdminSendMessage`
   - **Client diagnostics**: `ListConsumerConnection`, 
`GetConsumerRunningInfo`, `PrintThreadStackTrace`, `VerifyMessage`
   - **Runtime**: `GetProxyRuntimeStats`
   
   Design notes:
   
   - All request/response messages reuse existing `definition.proto` types 
(`Resource`, `Status`, `FilterExpression`, `MessageQueue`, `Message`, 
`SystemProperties`, `MessageType`).
   - Every message, field and RPC is documented with inline comments.
   - No multi-tenant / vendor-specific fields are included; names map directly 
to broker resources.
   
   ## Points for discussion
   
   - This PR re-introduces a `MessageModel` enum (CLUSTERING / BROADCASTING) 
local to `admin.proto` for subscription/consumer diagnostics. ChangeLog item 8 
removed `MessageModel` from the data plane; reviewers may prefer a different 
name or placement.
   - `GetProxyRuntimeStats` is named after the proxy deployment; open to 
renaming (e.g. `GetRuntimeStats`) if a broker-embedded gateway is preferred.
   - Server-side implementation and CRUD operations 
(CreateTopic/DeleteTopic/CreateGroup, GetClusterInfo) are intentionally out of 
scope and can follow in later PRs.
   
   ## Verification
   
   - `bazel build //:rocketmq_v2_proto` — passes
   - `bazel build //java:rocketmq-proto` — passes, generates `AdminGrpc` stubs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to