Aias00 opened a new pull request, #557:
URL: https://github.com/apache/rocketmq-dashboard/pull/557

   ## Summary
   - enable bean validation on data source create/update/test endpoints
   - require data source name, type, and url before invoking settings service 
logic
   - add controller tests for invalid data source requests
   
   ## Scope
   - RocketMQ Studio contest scope: Track 1 / METRICS-01 Prometheus and custom 
data source management hardening
   - Keeps existing endpoint formats such as `host:port` valid; this does not 
add URL format restrictions
   
   ## Tests
   - 
`JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home
 mvn -q -Dtest=SettingsControllerTest,SettingsServiceTest test`
   - 
`JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home
 mvn -q test`
   - `git diff --check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to