Aias00 opened a new pull request, #576:
URL: https://github.com/apache/rocketmq-dashboard/pull/576

   ## Summary
   - add MetricsController coverage for blank PromQL expressions, non-positive 
start timestamps, and blank query steps
   - assert invalid requests return 400 before reaching the metrics service
   
   ## Validation
   - 
`JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home
 mvn -q -Dtest=MetricsControllerTest test`
   - 
`JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home
 mvn -q test` (50 surefire files, 296 tests, 0 failures, 0 errors)
   - `git diff --check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to