yx9o opened a new pull request, #579:
URL: https://github.com/apache/rocketmq-dashboard/pull/579

   ## What is the purpose of the change
   
   Fixes #578 .
   
   K8s certificate update and renewal operations mutated the repository-held
   object before calling `save`. This allowed readers to observe intermediate
   state and allowed a failed save to leave changes from a failed request in
   memory. This change uses copy-on-write so repository state is replaced only
   when `save` succeeds.
   
   This complements #556, which validates REST request DTOs; this change 
protects
   service and repository state during valid update and renewal operations.
   
   ## Brief changelog
   
   - Build update and renewal results from copies instead of mutating stored 
objects.
   - Preserve certificate IDs, creation timestamps, omitted fields, and 
metadata.
   - Publish the new state only through the repository `save` operation.
   - Add regression tests for successful writes and repository save failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to