Aias00 commented on PR #10652: URL: https://github.com/apache/rocketmq/pull/10652#issuecomment-5082340212
Addressed the review feedback in `a998906f3`: - Documented the broker-sticky null-return contract in `ReceiveMessageQueueSelector` Javadoc. - Added a call-site comment clarifying that reentrant FIFO POP must stay on the original broker instead of falling back. - Added coverage for FIFO receive with `attemptId` to verify the sticky selector is passed into `popMessage` and returns no queue when the original broker is unavailable. Local verification: `mvn -pl proxy -Dtest=ReceiveMessageActivityTest test` passed with 10 tests; `git diff --check` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
