Aias00 commented on PR #10653: URL: https://github.com/apache/rocketmq/pull/10653#issuecomment-5082396505
Addressed the review feedback in `0087ac958`: - Moved the broker notification timeout into `NamesrvConfig` as `notifyMinBrokerIdChangeTimeoutMillis` with the same 3000ms default. - Updated `RouteInfoManager` to read the timeout from namesrv config instead of a static constant. - Extended the existing test to verify both the default timeout and a configured override value. Local verification: `mvn -pl namesrv -am -Dtest=RouteInfoManagerNewTest#notifyMinBrokerIdChangedUsesBrokerNotificationTimeout -DfailIfNoTests=false test` passed; `git diff --check` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
