This is an automated email from the ASF dual-hosted git repository.
fuyou001 pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 00e45b8a6d [ISSUE #10025] Treat blank local serve address as unset
(#10663)
00e45b8a6d is described below
commit 00e45b8a6db23efbe756d0306f10716156cfd4dd
Author: aias00 <[email protected]>
AuthorDate: Mon Jul 27 02:33:45 2026 -0700
[ISSUE #10025] Treat blank local serve address as unset (#10663)
---
.../apache/rocketmq/proxy/config/ProxyConfig.java | 2 +-
.../rocketmq/proxy/config/ProxyConfigTest.java | 38 ++++++++++++++++++++++
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
index 3068109835..a7896c11e0 100644
--- a/proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
+++ b/proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
@@ -296,7 +296,7 @@ public class ProxyConfig implements ConfigFile {
@Override
public void initData() {
parseDelayLevel();
- if (StringUtils.isEmpty(localServeAddr)) {
+ if (StringUtils.isBlank(localServeAddr)) {
this.localServeAddr = NetworkUtil.getLocalAddress();
}
if (StringUtils.isBlank(localServeAddr)) {
diff --git
a/proxy/src/test/java/org/apache/rocketmq/proxy/config/ProxyConfigTest.java
b/proxy/src/test/java/org/apache/rocketmq/proxy/config/ProxyConfigTest.java
new file mode 100644
index 0000000000..60e6bc6aa7
--- /dev/null
+++ b/proxy/src/test/java/org/apache/rocketmq/proxy/config/ProxyConfigTest.java
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.proxy.config;
+
+import org.apache.commons.lang3.StringUtils;
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class ProxyConfigTest {
+
+ @Test
+ public void initDataShouldResolveBlankLocalServeAddr() {
+ ProxyConfig proxyConfig = new ProxyConfig();
+ proxyConfig.setLocalServeAddr(" \t ");
+ proxyConfig.setRemotingAccessAddr(" ");
+
+ proxyConfig.initData();
+
+
assertThat(StringUtils.isBlank(proxyConfig.getLocalServeAddr())).isFalse();
+
assertThat(proxyConfig.getRemotingAccessAddr()).isEqualTo(proxyConfig.getLocalServeAddr());
+ }
+}