RockteMQ-AI commented on issue #10667: URL: https://github.com/apache/rocketmq/issues/10667#issuecomment-5102100744
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase (`develop` branch, commit `00e45b8a6`). **Root Cause:** In `PopConsumerCache.cleanupRecords()`, expired records with `visibilityTimeout <= currentTime` are passed to `consumer.accept(record)` (the revive callback), but: 1. The return value (future) is discarded — asynchronous failures are silently ignored 2. These records are not added to `writeConsumerRecords`, so they are not persisted to the store 3. `clearStagedRecords()` then unconditionally clears the entire `removeTreeMap` If the revive future completes exceptionally (e.g., `reviveRetry` throwing inside the chain), the record has already been removed from cache and was never persisted, resulting in silent message loss. **Impact:** POP consumer checkpoints can be lost when `enablePopBufferMerge=true` and an asynchronous revive fails. Affected consumers lose their un-acked message checkpoints. **Severity:** High — potential message loss in production under specific failure conditions. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
