RockteMQ-AI commented on issue #10678: URL: https://github.com/apache/rocketmq/issues/10678#issuecomment-5112807255
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The missing empty-entries validation in `AckMessageActivity.ackMessage` has been verified against the current `develop` branch. **Root Cause:** `AckMessageActivity.java:57` accesses `request.getEntries(0)` to determine batch-ack mode before any validation that the entries list is non-empty. When a gRPC client sends an `AckMessageRequest` with zero entries, this throws `IndexOutOfBoundsException` instead of returning a structured `BAD_REQUEST` error. **Impact:** Invalid client requests surface as internal Proxy errors (500-class) rather than client-side errors (400-class), making diagnosis harder for operators and clients. **Severity:** Medium — no data corruption, but incorrect error semantics and noisy error logs. **Suggested fix:** Add an entries-empty check before line 57, returning `GrpcProxyException(Code.BAD_REQUEST, "ack message entries cannot be empty")`. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
