RockteMQ-AI commented on issue #10672:
URL: https://github.com/apache/rocketmq/issues/10672#issuecomment-5112810980
**Issue Evaluation**
Category: `type/bug` | Status: **Confirmed**
The full-TelemetryCommand logging in
`GrpcClientChannel.writeTelemetryCommand` has been verified against the current
`develop` branch.
**Root Cause:** `GrpcClientChannel.java:278` — `log.warn("write telemetry
failed. command:{}", command, exception)` serializes the complete
`TelemetryCommand` when the telemetry observer is missing or
`observer.onNext()` fails. Some telemetry commands (e.g.
`VerifyMessageCommand`, `RecoverOrphanedTransactionCommand`) can carry message
payloads.
**Impact:** Operational logs may contain message content and produce
excessive log volume during client disconnections.
**Severity:** Low — diagnostics quality and potential sensitive-data-in-logs
issue, no functional impact.
**Suggested fix:** Replace full `command` logging with a compact summary
(command type, channel/client ID) while preserving enough context for debugging
telemetry write failures.
An automated fix proposal will be generated. Reply `/approve` to proceed
with PR generation.
---
*Automated evaluation by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
