RockteMQ-AI commented on PR #10679: URL: https://github.com/apache/rocketmq/pull/10679#issuecomment-5113224111
## Review by github-manager-bot ### Summary Adds an upfront validation for empty `AckMessageRequest.entries` before accessing `getEntries(0)`, preventing `IndexOutOfBoundsException` on invalid client input. Includes a regression test. ### Findings - **[Info]** `AckMessageActivity.java:58` — The empty-entries check is correctly placed before the `getEntries(0)` call and the batch-ack routing logic. Good defensive fix. - **[Info]** `AckMessageActivityTest.java:159` — Test correctly enables batch ack mode and verifies both the exception type and message. Clean coverage. ### Suggestions None — this is a clean, well-targeted fix with appropriate test coverage. --- *Automated review by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
