RockteMQ-AI commented on issue #10681: URL: https://github.com/apache/rocketmq/issues/10681#issuecomment-5113873066
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** `GrpcClientSettingsManager.offlineClientLiteSubscription()` at line 241 directly accesses `settings.getSubscription().getSubscriptions(0)` without checking if the subscriptions list is empty. When a lite consumer has incomplete settings (e.g., `ClientType.LITE_PUSH_CONSUMER` with no subscription entries), this throws `IndexOutOfBoundsException`. **Impact:** Proxy gRPC client disconnect/offline handling produces noisy error logs for incomplete settings. The broad catch block logs the full settings object at error level, which is both a log pollution issue and a potential information leak. **Severity:** low — No data loss or functional impact; the exception is caught and the cleanup is skipped via the exceptional path. **Suggested Fix:** Add an empty-check on `getSubscriptionsList()` before indexing, and return early if the list is empty. Avoid logging the full settings object in the error path. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
