Aias00 opened a new issue, #10685:
URL: https://github.com/apache/rocketmq/issues/10685

   ### Bug description
   
   `GrpcConverter.buildSystemProperties` parses timer message properties with 
`Long.parseLong` when building the gRPC `SystemProperties.delivery_timestamp` 
field:
   
   - `MessageConst.PROPERTY_TIMER_DELAY_SEC`
   - `MessageConst.PROPERTY_TIMER_DELIVER_MS`
   
   If either property is present but malformed, `buildMessage` can throw 
`NumberFormatException` while converting a Broker `MessageExt` into the gRPC v2 
`Message` response. This can make a single malformed timer property fail the 
whole gRPC message response/query conversion path.
   
   ### Expected behavior
   
   The converter should tolerate malformed optional timer properties. Valid 
timer properties should still set `delivery_timestamp`; malformed values should 
be ignored with a diagnostic warning instead of failing the message conversion.
   
   ### Affected area
   
   `proxy` module, gRPC v2 message conversion.
   
   ### Suggested fix
   
   - Parse timer properties through a safe helper.
   - Keep existing behavior for valid `PROPERTY_TIMER_DELAY_SEC` and 
`PROPERTY_TIMER_DELIVER_MS` values.
   - Ignore malformed values and log a warning with diagnostic context.
   - Add unit tests for valid and malformed timer properties.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to