ai-yang opened a new pull request, #679: URL: https://github.com/apache/rocketmq-dashboard/pull/679
### Which Issue(s) This PR Fixes - Fixes #678 ### Brief Description Reject out-of-range numeric broker configuration values before they reach the service while preserving partial updates. - Add nullable Bean Validation bounds for message size, retention time, queue counts, and broker permissions. - Cover every invalid side and valid boundary at the controller layer, plus an `id`-only partial update. - Document each unit, inclusive range, and optional field in the Cluster configuration API. ### Root Cause `UpdateConfigDTO` declared the numeric configuration fields without range constraints even though the controller already applies `@Valid`. As a result, negative, zero, and excessively large values were passed to `ClusterService`. ### Impact Invalid non-null values now receive HTTP 400 with stable validation messages and never invoke the service. Omitted fields remain valid and retain the existing partial-update behavior. `flushDiskType` parsing and service semantics are unchanged. ### How Did You Test This Change? - TDD regression check: all 10 invalid cases returned HTTP 200 before the constraints were added. - Java 21 Docker: `ClusterControllerTest` (28 tests passed). - Java 21 Docker: full server `mvn -q test`. - Maven Checkstyle: 0 violations. - `git diff --check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
