lizhimins commented on PR #658: URL: https://github.com/apache/rocketmq-dashboard/pull/658#issuecomment-5140614506
Reworked before merge: the trunk already has a generic alert rule module (`/api/alert-rules`, `AlertRuleVO` with metric/operator/threshold), so a dedicated `branch-compensate-alert-rules` CRUD stack would duplicate it per metric. Instead, this PR now extends the existing module: `AlertRuleVO` gains `brokerName`/`clusterName` scope and `severity` fields, the Prometheus export renders label selectors and rule severity, and replication/slave metrics are grouped under broker rules. Replication lag alerts can be created via the existing endpoints with e.g. `metric=rocketmq_broker_replication_lag_bytes`. Authorship preserved. Thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
